James Brock comments

Results 280 comments of


                                            James Brock

Let's rewrite the checks in message_reader::init()

> 1. The checksum we do not verify ( We have the option to verify the checksum though. We leave it to the library user to decide if they want...

Support for CMake

Hi @rossb34 , I'm open to this, but I don't use Cmake. Do you want to make a PR? We would also want a .nix shell file which provides a...

"packed representation"?

"zero-copy serialization" https://gitlab.haskell.org/ghc/ghc/-/wikis/linear-types

Error in next_message_reader

Yeah, good point. That's a rare case but it could occur. That should be fixed. Do you want to make a PR?

hffix_fields.hpp: Use X macros to simplify and add msg_type enum

Thanks for the PR! I can't look at this right now; will look in a few weeks.

(These lines are from the example programs `writer01.cpp` and `reader01.cpp`.) On reflection, this is fine: ```c++ for (; reader.is_complete(); reader = reader.next_message_reader()) { ``` But maybe this ```c++ hffix::message_writer new_order(logon.message_end(),...

James Brock