James Cobb-Walsh

Results 21 comments of James Cobb-Walsh

After some more investigation, this issue occurs without the `--upgrade` flag if there is no existing output file. It only "works" if `--upgrade` is not given and the output file...

> is that a reasonable and good expectation? > we probably should make that clearer in the docs I was going to say that this is definitely a reasonable solution,...

I've added some tests to validate your changes, and opened a PR into your fork. Looks like your changes solve the problem, from the test output

Great, thanks for this! I agree, I think this becomes much more predictable. So does this new behaviour account for the case where there is no `requirements.in` file, but requirements...

@tboddyspargo The final point here, constraining `azure-core` and the expectation to find the highest version of all dependencies with the `-U` flag _combined_ with the `-P "azure-core~=1.22.0"` is the issue...

Thanks for your debugging @ferstar, saved me a LOT of time with this issue. Completely agree, simply returning `None` is very confusing for the user here, and some log statement...

After a bit more searching, I can now see this grouping happens by fragment content [here](https://github.com/twisted/towncrier/blob/ab08d55885f3bfaf8250bc812bcb9d2f9935d8f0/src/towncrier/_builder.py#L173). Some comment/documentation should be added to reflect that this is possible and this is...

It would have helped if I'd used permalinks (issue now edited), so I'll update the links to show the issue. At the time, [this comment](https://github.com/twisted/towncrier/blob/ab08d55885f3bfaf8250bc812bcb9d2f9935d8f0/src/towncrier/_builder.py#L251) was in the `render_fragments` section....

@adiroiban Thanks for clarifying the current behaviour - I suspect this didn't work when I opened the issue in 2021. It was more about documenting the behaviour, and as this...