James Crosswell

Results 518 comments of James Crosswell

> You can use an `if` element on your CI job that checks the GITHUB_REPOSITORY_OWNER variable (against `getsentry` value of course). If I've understood, you're saying we could add some...

> Sorry, a single `if` line of code is "a lot of complexity"? Whilst I appreciate the rationale, I don't much appreciate the sarcasm. We're just talking about software here....

> I've run into flaky `Sentry.Tests.MetricAggregatorTests.GetFlushableBuckets_IsThreadsafe` [here](https://github.com/getsentry/sentry-dotnet/actions/runs/7725080445) That sounds like a different issue - there might be a genuine concurrency problem there. I've created a new issue for that.

This is getting worse and worse - had to rerun it twice to get it to pass on this branch: We could do that automatically (retry upto max n times)...

> Also, with regard to #2066 - we should not be setting transactions bridged from otel spans on the scope at all. Would love to know the rational for this...

> Would love to know the rational for this as I've possibly already gone and broken things: I think I might have had an Aha moment. Folks can set `Scope.Transaction`...

A couple of thoughts: - It seems like a prerequisite to this is aligning the way Sentry and OTEL represent traces... specifically, OTEL doesn't distinguish between Transactions and Spans (in...

### Transaction vs Span ```diff + AddBreadcrumb(Breadcrumb breadcrumb) : void + Breadcrumbs : IReadOnlyCollection + Contexts : SentryContexts Description : string? + Distribution : string? EndTimestamp : DateTimeOffset? + Environment...

Hi @Liklainy, thanks for getting in touch. @bitsandfoxes we could fairly easily implement our own `EnsureSuccessStatusCode` for target frameworks below `.net5.0`. I know Matt was against this on principal, as...

I think this was fixed in https://github.com/getsentry/sentry-dotnet/pull/3382 then. Feel free to re-open if you're still having issues with the 4.7.0 release or later though.