James Crosswell

Results 518 comments of James Crosswell

> As a workaround, could you see if you can use ILogger to report exceptions, assuming you control the code which currently calls RecordException? Unfortunately not @cijothomas. I'm working on...

I found an [existing issue](https://github.com/open-telemetry/opentelemetry-specification/issues/955) in the opentelemetry-specification repo. It looks like for Java, something like this was implemented already? - https://github.com/open-telemetry/opentelemetry-java/pull/4162

I see. Is there anything more recent available that will build for MacOS?

> @jamescrosswell you looked into filtering async await magic from the codelocations. Do you think this is something we can reuse here? Possibly yes. Just have to decide whether we...

I can't seem to reproduce this. This is my attempt to reproduce the problem simply: - https://github.com/jamescrosswell/EFCoreGrouping

The python implementation appears to [use a combination](https://github.com/getsentry/sentry-python/blob/1f27ad465ac283acad58c851e3f4a031ac2cb89d/sentry_sdk/transport.py#L326-L328) of whether the [queue is full](https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/worker.py#L102-L104) or whether [requests have been rate limited](https://github.com/getsentry/sentry-python/blob/1f27ad465ac283acad58c851e3f4a031ac2cb89d/sentry_sdk/transport.py#L318-L320) to [adjust a downsample factor](https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/monitor.py#L90-L91). This is then used...

> If traces get rate limited errors get downsampled? No the other way around... Downsampling only affects traces in the Python implementation. However if Metrics or Errors get rate limited,...

We could/should be able to control everything via the `DiagnosticLevel` right? https://github.com/getsentry/sentry-dotnet/blob/0711c17f539a1083ca783555db37368267d32176/src/Sentry/SentryOptions.cs#L641 So SentryOptions.Debug is a bit redundant... although lots of customers will definitely know about it so if we...

> The main gripe I have with the current code is the need to enable Debug to get **any logs**, even warnings Yeah fair enough. What do you think should...