James C. De Ricco
James C. De Ricco
Thanks for all your feedback @tobbi and @Vankata453! I pushed commits that fix all the easy code style changes, I will work on resolving your remaining feedback tomorrow.
> What is the current state of this PR? @mrkubax10 I am resolving remaining feedback on this PR. In particular, right now I am working on supporting translations.
> What still needs to get done here? # To Do - **WIP**: Finish refactor to use item_processor - Plan how to remove English phrases from the author field to...
> Is this done? This is work in progress. All functionality and translations are complete. Still left to do are updating music metadata, like title, author and license, for recent...
This pull request is ready for code review and merging! I completed all the remaining work that I mentioned in my last status update 3 weeks ago. The code now...
> Works great! You can see all important information about a music file: > >  > > Left 2 minor code-related comments. If you agree with any of them,...
I started work on this issue in the branch [2617-music-author](https://github.com/jamescdericco/supertux/tree/2617-music-author) of my fork.
I finished making a UI mockup for this. I would like your feedback before starting implementation. Do you all like this or is there anything you prefer added, subtracted or...
> > In the design below, we display music metadata, including author, when hovering over music files in the hover "help text" below the menu: > > Personally, I like...
I tried a UI design where the filename was emphasized using a big font and activetextcolor (blue stroke). But I see your point @Vankata453, it may be better to be...