James Casbon

Results 38 comments of James Casbon

Mistaken close ;)

@cjav please see #145. I will check this out when I get a minute.

@mbreese @cjav @jeremiahsavage please try 0.6.7

VCF writing kind of snuck in to this project without proper development - in a way it was to easy. @omergerdan please can we have a test case, as this...

Thanks, this looks good but I'm not really willing to merge it without any tests. Can you add some, please? Also, idea is normalising whitespace which is a bit irritating....

Hi, thanks for adding tests. I will check this out now with a view to merging. ccing @martijnvermaat in case he gets there first.

Hi Carlos, How do you handle the case where both a.vcf and b.vcf have A->T and A->C mutations, return the product? Does the latest version of the walk_together key function...

No, I mean... (a.r1, b.r1), (a.r2, b.r2), (a.r1, b.r2) (a.r2, b.r1) It follows from your first suggestion, right?