James Rich
James Rich
There's no caching implementation currently, this is probably very dependent on your internet connection (and api ratelimits) currently.
does this have a parent issue on the design board @b8b8 ? seems like we would want to align the implementation cross-platform.
> @jamesarich Hi, do I need to take further steps to mark this PR for review? Just patience. We're volunteers and busy 😅
@1nv just wanted to say thanks again for the contribution 🤝. If you're interested in contributing more regularly, feel free to reach out on [discord](https://discord.gg/meshtastic) - I'm `@olm3c`. We can...
How y'all feeling about this, @jakevis @RCGV1 ? Should we let copilot do a review pass?
@jakevis you'll need to run `./gradlew spotlessApply detekt` and clean up any errors
> 🤦♂️ Will do, sorry about that. no worries, it's a common gotcha most new contribs miss - so much so that we thought about scripting an action to remind...
@jakevis Instead of suppressing the Detekt warnings, let's actually clean up the code. The errors are pretty descriptive of what needs to happen.
> @jakevis Instead of suppressing the Detekt warnings, let's actually clean up the code. > > The errors are pretty descriptive of what needs to happen. I usually try to...
> so apparently that's how it likes to fix things dang ol' robots