James O'Brien

Results 19 comments of James O'Brien

Two quick questions: 1. Should this happen after #5513 in order to prevent adding work to that PR? If 5513 isn't going to be merged for a while and we...

I need to leverage clocks for my use case. I had started manually depending on kira directly in order to gain access to them but it would be great to...

I have a fork that has basic, quick and dirty support here: https://github.com/james-j-obrien/bevy_kira_audio Missing docs and dynamic clock support but appears to work as expected.

> I'll give a more detailed review later but just from the examples I think providing the system before the system params the wrong way to do this. The system...

I wish we could easily implement such a dynamic API but that would require far more extensive changes then I've made here. You could dynamically fill the tuple with a...

I understand the API you're proposing, but in order to turn one query state into another at some point you need to call the query `transmute` method to re-create the...

Did a refactor to base it on partial tuples bringing it more in line with the API both @iiYese and I would prefer. The main rough edge here is that...

The PR is broadly functional and the API is pretty close to what I expect the final API to look like. Before this would be ready to be merged there...

I have added a modest set of tests, fixed several bugs and revamped the example to be more complex. I'm going to take this out of draft now that I...

Yep, I think that's a good idea and had considered something similar. I can fold that into this PR pretty easily 👍