Jamal James

Results 132 comments of Jamal James

Good point. I'd agree the placeholder should display a more realistic value. Thanks for the feedback.

Here's some specific events that I would be helpful for the UI. These are events that occur without any user action, so the only way to get the data is...

> @jamaljsr I assume you'd like to know the first two events independent of whether the daemon was involved in them or not? To update the list of all known...

Yes, this is something that would be very useful for the UI as well as others integrating with `poold` in the future. Currently, the UI is polling, which works but...

Thanks for the feedback 👍 > Suggest to present fee as "maximum fee" so that it's clear that this is an upper estimate and may not be the actual price....

Ahh, ok. I know what you mean now. Yes, the `loop` CLI will display both the "estimated" and the "max" on-chain sweep fee. The "max" value is 100x the "estimated"....

Thanks for the bug report as i wasn't aware that storybook wasn't functioning. I suspect this was caused by #350. We'll work on getting this fixed.

Yes, my first course of action would be to update the storybook packages. You are more than welcome to give it a try if you'd like.

Thanks for the detailed update. I think you can update the package.json file to remove the resolution for history v4.10.1. This was there to resolve issues with the prior version...

Ah yes, after removing the `yarn.lock` file, I see the errors you are referring to. I guess the upgrade to `react-router` is going to be necessary. feel free to try...