Jakub Chodounsky

Results 14 comments of Jakub Chodounsky

Hi Dave I would start with email on commit and on commit with tag. It would be nice to have it configurable.

I would prefer configuration per repository for the current user - he can select if he wants to receive notifications for current repo - what do you think?

This is one option, another one would be creating a new database table - something like UserRepository_Email. Do you think this approach could be cleaner?

I see your point, mine was separation of concerns, your is data redundancy - I guess you can choose one or the other and possibly change it in the future...

Maybe email settings per repository is too granular. It would probably be ok if you just selected if you want to receive commit notifications or not in your account settings....

For the SMTP settings there are two options: have them in web.config or in global settings XML file (and appropriate create appropriate UI elements for it). I don't have any...

Hi Dave, congratulations!! and please don't apologize. I am preparing for moving across the world, so I'm not as active as I should be as well. Good luck!

New listener should be notified from GitController (https://github.com/jakubgarfield/Bonobo-Git-Server/blob/master/Bonobo.Git.Server/Controllers/GitController.cs)

Not yet, you can give it a try :)

1) these settings could be configured in web.config - no need to bother with UI 2) true 3) that make sense, but it could be added later, firstly you can...