John Litborn

Results 432 comments of John Litborn

oh actually, probably nice to add to the comment that it's only saved for the sake of external post-teardown inspection; and not required internally. If there's any docs for the...

> Guys, are we waiting for something?) Looks like we did all stuff from reviewers it's usually good habit to wait a couple days to see if anybody else wants...

Agree it should just link to https://pytest--13192.org.readthedocs.build/en/13192/how-to/assert.html#assertions-about-expected-exceptions for more details. I'll make some changes in #13192

I just hit this one, and wrote up a long and thorough issue before I tried searching for an existing issue and found this one :upside_down_face: I'll just copy-paste the...

> > Introduce a second, `WithAsName` class. > > I think this is the more correct approach, but can we make it a backwards compatible change at least for valid...

@tmaxwell-anthropic any opinions on the detailed behaviour, or in what ways it would be maximally useful for cases such as yours? See in-line comments. Fixed CI issues*, and testing to...

> * What happens if the kernel dies, but then the auto-restarter restarts it? Ideally, the user should be notified that the kernel was restarted, and also why it was...

> Another option might be to add a second set of callbacks, with different names, which are equivalent except that they take an extra parameter. So the component that's registering...

made a somewhat messy (esp when you look at the typing) implementation for restarter callback taking the exit status, and wrote (copy-paste+modified) a test for it. A more creative test...

Shouldn't this be reported primarily in https://github.com/jupyter-server/jupyter_server? Only once the server has support for it could any eventual client-side support be handled.