John Litborn comments

Results 429 comments of


                                            John Litborn

Enforce order of decorators combined with `@abstractmethod`

Sounds quite reasonable, especially if the error message in #281 will suggest using a combination instead of the deprecated `@abstractproperty`. See e.g. https://github.com/python/cpython/issues/60471 for discussion around why the wrong order...

Switch to a new parser

LibCST now supports (according to readme) 3.0->3.11, though it does say > It is more difficult to implement tools that focus almost exclusively on whitespace on top of LibCST instead...

False positive B023

I'm on it!

False positive B023

The PR should fix a bunch of the false alarms mentioned in here, but probably not all of them. Feel free to check it out

False positive B023

Done~ :slightly_smiling_face:

Black collapses lists in return type annotations onto one line, regardless of the "magic" trailing comma.

> or just: > > ```python > a: list[int,] > ``` > > With `skip-magic-trailing-comma` nothing is changed. This is intended behavior (though I'm not sure why), and probably unrelated:...

Black collapses lists in return type annotations onto one line, regardless of the "magic" trailing comma.

I dug further into this, and it ended up revealing that `left_hand_split()` needs its logic revamped since the addition of return types. I found a bunch of other incorrect cases:...

Black collapses lists in return type annotations onto one line, regardless of the "magic" trailing comma.

@JelleZijlstra (and/or others) I got one case which I'm a bit iffy about, currently the code will reformat very long single-name return types and function names like so: ```python def...

wall clock timing functionality

> It's a pity this didn't quite make it to production, especially since it seems like it's mainly because FreeBSD is hard (which is very worthwhile but not the most...

Annotate function which return a specific module (e.g. `-> Literal[np]`)

You can be creative with the `TYPE_CHECKING` guard, and certainly don't have to do it in the global scope. Something like this might work as well (untested): ```python from typing...