Jake Zych comments

Results 5 comments of


                                            Jake Zych

Fixes no error thrown for Final fields declared with init=False and not assigned inside init

I think I fixed the issue. Could someone rerun the workflows?

Fixes no error thrown for Final fields declared with init=False and not assigned inside init

I'll see if I can set up mypy primer locally to get a better idea of what's going wrong.

Fixes no error thrown for Final fields declared with init=False and not assigned inside init

I tested the changes locally on yarl and discord.py and it was not throwing the errors anymore.

Fixes no error thrown for Final fields declared with init=False and not assigned inside init

~~I'm a bit confused about the `self.y = 3 #typo here` line. Shouldn't it be okay to assign a final field in the `__post_init__ `method?~~ I'm silly and didn't read...

Fixes no error thrown for Final fields declared with init=False and not assigned inside init

It does show errors from third-party libraries, I assume we want to suppress those?

Jake Zych

Fixes no error thrown for Final fields declared with init=False and not assigned inside __init__

Fixes no error thrown for Final fields declared with init=False and not assigned inside __init__

Fixes no error thrown for Final fields declared with init=False and not assigned inside __init__

Fixes no error thrown for Final fields declared with init=False and not assigned inside __init__

Fixes no error thrown for Final fields declared with init=False and not assigned inside __init__

Fixes no error thrown for Final fields declared with init=False and not assigned inside init

Fixes no error thrown for Final fields declared with init=False and not assigned inside init

Fixes no error thrown for Final fields declared with init=False and not assigned inside init

Fixes no error thrown for Final fields declared with init=False and not assigned inside init

Fixes no error thrown for Final fields declared with init=False and not assigned inside init