Jake Bailey

Various node builder related performance optimizations

2

Did some profiling of this overnight. - Eliminate the closures; this can be done through the same tricks used in the parser to avoid binding. This reduces some 10%+ allocations....

Followup to https://github.com/microsoft/typescript-go/pull/971#discussion_r2114352757, but this makes creating globs a bit slower due to the FS accesses to see if things are symlinked.

Implement externalModuleIndicator

3

The infamous `externalModuleIndicator` field requires access to info like the module setting of the closest package.json in order to work in some situations. This is normally "fine"; just make a...

Evolving arrays don't work in JS

3

```js const foo = [] for (let i = 0; i < 10; i++) { foo.push(i) } console.log(foo) ``` Nets: ``` Argument of type 'number' is not assignable to parameter...

In `Herebyfile.mjs`, I wrote: ``` /** * @type {{ [K in keyof typeof rawOptions as {} extends Record ? never : K]: typeof rawOptions[K] }} */ const options = rawOptions;...

No baselines in this PR yet; want to double check with people that these minimal changes won't break too much.

go.alternateTools does not automatically add .exe (or similar) on Windows, missing "which" call?

8

### What version of Go, VS Code & VS Code Go extension are you using? Version Information * Run `go version` to get version of Go from _the VS Code...

Be strict about package.json JSON syntax

6

Corsa is strict about this, so tests break in weird ways due to these random trailing commas/comments. Be strict here, then fix the tests.

Spurious "referenced directly or indirectly in its own initializer" when combined with narrowing, asserts function, and loop

3

# Bug Report ### 🔎 Search Terms referenced directly or indirectly asserts ### 🕗 Version & Regression Information - This is the behavior in every version I tried ### ⏯...