TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

Be strict about package.json JSON syntax

Open jakebailey opened this issue 6 months ago • 6 comments

Corsa is strict about this, so tests break in weird ways due to these random trailing commas/comments.

Be strict here, then fix the tests.

jakebailey avatar Jun 18 '25 21:06 jakebailey

@typescript-bot test it

jakebailey avatar Jun 18 '25 21:06 jakebailey

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

typescript-bot avatar Jun 18 '25 21:06 typescript-bot

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot avatar Jun 18 '25 21:06 typescript-bot

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61901/merge:

Everything looks good!

typescript-bot avatar Jun 18 '25 21:06 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 194,161k (± 0.94%) 194,746k (± 1.04%) ~ 192,891k 196,709k p=0.470 n=6
Parse Time 1.30s (± 1.02%) 1.31s (± 0.62%) ~ 1.29s 1.31s p=0.527 n=6
Bind Time 0.73s (± 0.56%) 0.73s ~ ~ ~ p=0.405 n=6
Check Time 9.65s (± 0.44%) 9.68s (± 0.29%) ~ 9.64s 9.71s p=0.373 n=6
Emit Time 2.74s (± 0.85%) 2.74s (± 0.43%) ~ 2.72s 2.75s p=0.746 n=6
Total Time 14.42s (± 0.25%) 14.45s (± 0.22%) ~ 14.42s 14.49s p=0.372 n=6
angular-1 - node (v18.15.0, x64)
Errors 56 56 ~ ~ ~ p=1.000 n=6
Symbols 948,750 948,750 ~ ~ ~ p=1.000 n=6
Types 410,846 410,846 ~ ~ ~ p=1.000 n=6
Memory used 1,224,564k (± 0.00%) 1,224,996k (± 0.00%) +432k (+ 0.04%) 1,224,967k 1,225,069k p=0.005 n=6
Parse Time 6.63s (± 0.25%) 6.54s (± 0.74%) -0.09s (- 1.33%) 6.47s 6.62s p=0.010 n=6
Bind Time 1.89s (± 0.47%) 1.87s (± 0.28%) -0.02s (- 0.88%) 1.87s 1.88s p=0.010 n=6
Check Time 31.84s (± 0.21%) 31.71s (± 0.20%) -0.13s (- 0.40%) 31.63s 31.78s p=0.020 n=6
Emit Time 14.88s (± 0.61%) 14.90s (± 0.41%) ~ 14.83s 14.98s p=1.000 n=6
Total Time 55.25s (± 0.13%) 55.03s (± 0.28%) -0.22s (- 0.40%) 54.82s 55.25s p=0.024 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,561,651 2,561,651 ~ ~ ~ p=1.000 n=6
Types 892,630 892,630 ~ ~ ~ p=1.000 n=6
Memory used 2,836,570k (± 0.00%) 2,836,640k (± 0.00%) +70k (+ 0.00%) 2,836,575k 2,836,709k p=0.020 n=6
Parse Time 9.19s (± 0.30%) 9.03s (± 0.31%) -0.16s (- 1.74%) 8.99s 9.06s p=0.005 n=6
Bind Time 2.29s (± 0.60%) 2.30s (± 0.33%) ~ 2.29s 2.31s p=0.740 n=6
Check Time 83.59s (± 0.57%) 83.93s (± 1.01%) ~ 82.63s 85.07s p=0.336 n=6
Emit Time 0.30s (± 1.37%) 0.30s (± 1.74%) ~ 0.29s 0.30s p=0.595 n=6
Total Time 95.37s (± 0.49%) 95.56s (± 0.86%) ~ 94.29s 96.67s p=0.689 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,126 1,227,124 -2 (- 0.00%) ~ ~ p=0.001 n=6
Types 267,408 267,407 -1 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 2,973,647k (±10.03%) 2,851,347k (±13.24%) ~ 2,362,639k 3,095,720k p=0.298 n=6
Parse Time 6.67s (± 1.10%) 6.61s (± 1.09%) ~ 6.52s 6.72s p=0.173 n=6
Bind Time 2.16s (± 1.62%) 2.19s (± 1.18%) ~ 2.15s 2.22s p=0.148 n=6
Check Time 42.86s (± 0.46%) 42.74s (± 0.52%) ~ 42.35s 43.02s p=0.378 n=6
Emit Time 3.44s (± 4.30%) 3.47s (± 2.72%) ~ 3.32s 3.59s p=0.810 n=6
Total Time 55.12s (± 0.41%) 55.02s (± 0.49%) ~ 54.60s 55.38s p=0.575 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,126 1,227,124 -2 (- 0.00%) ~ ~ p=0.001 n=6
Types 267,408 267,407 -1 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 2,550,240k (±11.64%) 2,429,808k (± 0.01%) ~ 2,429,608k 2,430,204k p=0.066 n=6
Parse Time 5.46s (± 1.88%) 5.42s (± 0.63%) ~ 5.37s 5.47s p=0.689 n=6
Bind Time 1.81s (± 2.41%) 1.82s (± 1.61%) ~ 1.78s 1.86s p=0.628 n=6
Check Time 35.22s (± 0.71%) 35.22s (± 0.25%) ~ 35.14s 35.37s p=0.470 n=6
Emit Time 3.01s (± 0.72%) 3.05s (± 0.52%) +0.04s (+ 1.50%) 3.03s 3.08s p=0.005 n=6
Total Time 45.50s (± 0.69%) 45.51s (± 0.18%) ~ 45.41s 45.63s p=0.378 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,474 262,472 -2 (- 0.00%) ~ ~ p=0.001 n=6
Types 107,135 107,134 -1 (- 0.00%) ~ ~ p=0.001 n=6
Memory used 441,741k (± 0.01%) 441,750k (± 0.01%) ~ 441,715k 441,792k p=0.810 n=6
Parse Time 3.52s (± 0.87%) 3.52s (± 0.47%) ~ 3.51s 3.55s p=0.935 n=6
Bind Time 1.32s (± 0.57%) 1.32s (± 0.92%) ~ 1.31s 1.34s p=0.485 n=6
Check Time 18.77s (± 0.30%) 18.80s (± 0.68%) ~ 18.68s 18.98s p=1.000 n=6
Emit Time 1.52s (± 1.53%) 1.52s (± 1.15%) ~ 1.50s 1.55s p=1.000 n=6
Total Time 25.14s (± 0.33%) 25.17s (± 0.53%) ~ 25.01s 25.34s p=0.689 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 71 71 ~ ~ ~ p=1.000 n=6
Symbols 225,327 225,327 ~ ~ ~ p=1.000 n=6
Types 94,288 94,288 ~ ~ ~ p=1.000 n=6
Memory used 371,139k (± 0.02%) 371,025k (± 0.01%) -114k (- 0.03%) 370,931k 371,073k p=0.013 n=6
Parse Time 2.88s (± 0.47%) 2.87s (± 1.16%) ~ 2.82s 2.90s p=0.807 n=6
Bind Time 1.60s (± 2.07%) 1.59s (± 1.22%) ~ 1.57s 1.62s p=0.518 n=6
Check Time 16.31s (± 0.41%) 16.33s (± 0.40%) ~ 16.25s 16.42s p=0.630 n=6
Emit Time 0.00s 0.00s (±244.70%) ~ 0.00s 0.01s p=0.405 n=6
Total Time 20.80s (± 0.41%) 20.80s (± 0.24%) ~ 20.73s 20.85s p=0.687 n=6
vscode - node (v18.15.0, x64)
Errors 33 33 ~ ~ ~ p=1.000 n=6
Symbols 3,471,686 3,471,686 ~ ~ ~ p=1.000 n=6
Types 1,167,320 1,167,320 ~ ~ ~ p=1.000 n=6
Memory used 3,518,662k (± 0.00%) 3,518,758k (± 0.00%) ~ 3,518,593k 3,518,886k p=0.378 n=6
Parse Time 14.99s (± 0.28%) 14.95s (± 0.54%) ~ 14.85s 15.07s p=0.336 n=6
Bind Time 4.84s (± 0.43%) 4.84s (± 0.50%) ~ 4.82s 4.88s p=0.871 n=6
Check Time 94.22s (± 2.80%) 95.86s (± 2.51%) ~ 92.79s 99.00s p=0.471 n=6
Emit Time 30.08s (± 1.87%) 30.37s (± 2.52%) ~ 29.26s 30.97s p=0.297 n=6
Total Time 144.14s (± 2.00%) 146.03s (± 2.12%) ~ 141.89s 149.47s p=0.689 n=6
webpack - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 320,000 320,000 ~ ~ ~ p=1.000 n=6
Types 140,356 140,356 ~ ~ ~ p=1.000 n=6
Memory used 474,117k (± 0.02%) 474,261k (± 0.02%) +144k (+ 0.03%) 474,164k 474,369k p=0.045 n=6
Parse Time 5.37s (± 0.41%) 5.41s (± 0.56%) ~ 5.37s 5.44s p=0.063 n=6
Bind Time 2.20s (± 0.80%) 2.20s (± 1.53%) ~ 2.16s 2.24s p=0.569 n=6
Check Time 25.70s (± 0.40%) 25.73s (± 0.25%) ~ 25.64s 25.82s p=0.630 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 33.26s (± 0.26%) 33.34s (± 0.17%) ~ 33.25s 33.41s p=0.126 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 667,036 667,036 ~ ~ ~ p=1.000 n=6
Types 198,508 198,508 ~ ~ ~ p=1.000 n=6
Memory used 569,713k (± 0.00%) 569,952k (± 0.01%) +239k (+ 0.04%) 569,877k 570,017k p=0.005 n=6
Parse Time 4.44s (± 0.60%) 4.23s (± 0.32%) 🟩-0.21s (- 4.73%) 4.21s 4.25s p=0.005 n=6
Bind Time 1.32s (± 1.07%) 1.33s (± 0.92%) ~ 1.31s 1.34s p=0.564 n=6
Check Time 20.66s (± 2.03%) 19.83s (± 0.36%) 🟩-0.83s (- 4.01%) 19.71s 19.93s p=0.005 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 26.42s (± 1.69%) 25.39s (± 0.27%) 🟩-1.03s (- 3.90%) 25.28s 25.48s p=0.005 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6
Developer Information:

Download Benchmarks

typescript-bot avatar Jun 18 '25 21:06 typescript-bot

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61901/merge:

Everything looks good!

typescript-bot avatar Jun 18 '25 22:06 typescript-bot

@typescript-bot test it

jakebailey avatar Jun 19 '25 23:06 jakebailey

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

typescript-bot avatar Jun 19 '25 23:06 typescript-bot

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61901/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot avatar Jun 20 '25 00:06 typescript-bot

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot avatar Jun 20 '25 00:06 typescript-bot

@jakebailey The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 194,179k (± 0.93%) 194,148k (± 0.93%) ~ 192,834k 196,531k p=0.936 n=6
Parse Time 1.30s (± 0.84%) 1.31s (± 0.31%) ~ 1.30s 1.31s p=0.178 n=6
Bind Time 0.73s 0.73s (± 0.56%) ~ 0.72s 0.73s p=0.405 n=6
Check Time 9.70s (± 0.31%) 9.68s (± 0.33%) ~ 9.63s 9.71s p=0.421 n=6
Emit Time 2.74s (± 1.08%) 2.74s (± 0.59%) ~ 2.72s 2.76s p=0.685 n=6
Total Time 14.46s (± 0.21%) 14.46s (± 0.24%) ~ 14.41s 14.51s p=1.000 n=6
angular-1 - node (v18.15.0, x64)
Errors 56 56 ~ ~ ~ p=1.000 n=6
Symbols 948,750 948,750 ~ ~ ~ p=1.000 n=6
Types 410,846 410,846 ~ ~ ~ p=1.000 n=6
Memory used 1,224,584k (± 0.00%) 1,224,984k (± 0.00%) +401k (+ 0.03%) 1,224,906k 1,225,085k p=0.005 n=6
Parse Time 6.62s (± 0.97%) 6.57s (± 1.34%) ~ 6.47s 6.66s p=0.171 n=6
Bind Time 1.88s (± 0.43%) 1.88s (± 0.22%) ~ 1.88s 1.89s p=0.584 n=6
Check Time 31.83s (± 0.13%) 31.77s (± 0.32%) ~ 31.63s 31.93s p=0.199 n=6
Emit Time 14.90s (± 0.51%) 14.85s (± 0.97%) ~ 14.68s 14.99s p=0.688 n=6
Total Time 55.24s (± 0.22%) 55.07s (± 0.55%) ~ 54.68s 55.46s p=0.297 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,561,658 2,561,658 ~ ~ ~ p=1.000 n=6
Types 892,631 892,631 ~ ~ ~ p=1.000 n=6
Memory used 2,836,582k (± 0.00%) 2,836,695k (± 0.00%) +113k (+ 0.00%) 2,836,635k 2,836,737k p=0.013 n=6
Parse Time 9.20s (± 0.30%) 9.05s (± 0.24%) -0.14s (- 1.56%) 9.02s 9.08s p=0.005 n=6
Bind Time 2.30s (± 0.22%) 2.30s (± 0.18%) ~ 2.30s 2.31s p=0.595 n=6
Check Time 83.48s (± 0.09%) 83.78s (± 0.26%) +0.29s (+ 0.35%) 83.48s 83.98s p=0.030 n=6
Emit Time 0.30s (± 1.37%) 0.30s (± 1.37%) ~ 0.29s 0.30s p=1.000 n=6
Total Time 95.28s (± 0.09%) 95.43s (± 0.22%) ~ 95.14s 95.64s p=0.335 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,126 1,227,127 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 267,408 267,408 ~ ~ ~ p=1.000 n=6
Memory used 2,362,643k (± 0.03%) 2,423,461k (± 6.15%) ~ 2,361,365k 2,727,974k p=0.575 n=6
Parse Time 5.18s (± 0.77%) 5.22s (± 1.17%) ~ 5.12s 5.30s p=0.335 n=6
Bind Time 1.80s (± 0.35%) 1.80s (± 0.67%) ~ 1.78s 1.81s p=0.310 n=6
Check Time 35.16s (± 0.31%) 35.09s (± 0.49%) ~ 34.83s 35.34s p=0.471 n=6
Emit Time 2.96s (± 1.27%) 3.01s (± 1.52%) +0.05s (+ 1.80%) 2.97s 3.10s p=0.030 n=6
Total Time 45.11s (± 0.32%) 45.15s (± 0.44%) ~ 44.96s 45.52s p=0.936 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,227,126 1,227,127 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 267,408 267,408 ~ ~ ~ p=1.000 n=6
Memory used 2,916,908k (±12.89%) 2,917,349k (±12.87%) ~ 2,431,898k 3,161,086k p=0.630 n=6
Parse Time 6.86s (± 1.45%) 6.84s (± 1.05%) ~ 6.72s 6.92s p=0.810 n=6
Bind Time 2.19s (± 1.77%) 2.16s (± 1.26%) ~ 2.14s 2.21s p=0.172 n=6
Check Time 42.77s (± 0.31%) 42.74s (± 0.57%) ~ 42.43s 42.98s p=1.000 n=6
Emit Time 3.56s (± 1.58%) 3.54s (± 1.56%) ~ 3.46s 3.61s p=0.689 n=6
Total Time 55.39s (± 0.36%) 55.30s (± 0.52%) ~ 54.88s 55.60s p=0.748 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,474 262,475 +1 (+ 0.00%) ~ ~ p=0.001 n=6
Types 107,135 107,135 ~ ~ ~ p=1.000 n=6
Memory used 441,722k (± 0.01%) 441,657k (± 0.03%) ~ 441,480k 441,783k p=0.471 n=6
Parse Time 3.54s (± 0.80%) 3.55s (± 0.64%) ~ 3.52s 3.58s p=0.686 n=6
Bind Time 1.33s (± 1.03%) 1.32s (± 0.89%) ~ 1.30s 1.33s p=0.406 n=6
Check Time 18.89s (± 0.39%) 18.84s (± 0.55%) ~ 18.73s 19.00s p=0.378 n=6
Emit Time 1.51s (± 1.14%) 1.54s (± 1.04%) +0.03s (+ 1.76%) 1.51s 1.55s p=0.028 n=6
Total Time 25.28s (± 0.41%) 25.26s (± 0.42%) ~ 25.13s 25.40s p=0.936 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 71 71 ~ ~ ~ p=1.000 n=6
Symbols 225,327 225,327 ~ ~ ~ p=1.000 n=6
Types 94,288 94,288 ~ ~ ~ p=1.000 n=6
Memory used 371,131k (± 0.04%) 371,133k (± 0.04%) ~ 371,042k 371,402k p=0.378 n=6
Parse Time 2.87s (± 1.72%) 2.87s (± 1.33%) ~ 2.84s 2.94s p=0.936 n=6
Bind Time 1.58s (± 1.89%) 1.59s (± 0.76%) ~ 1.58s 1.61s p=0.120 n=6
Check Time 16.23s (± 0.31%) 16.27s (± 0.28%) ~ 16.21s 16.33s p=0.170 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 20.68s (± 0.22%) 20.74s (± 0.25%) ~ 20.68s 20.80s p=0.147 n=6
vscode - node (v18.15.0, x64)
Errors 33 33 ~ ~ ~ p=1.000 n=6
Symbols 3,475,920 3,475,920 ~ ~ ~ p=1.000 n=6
Types 1,168,822 1,168,822 ~ ~ ~ p=1.000 n=6
Memory used 3,522,384k (± 0.01%) 3,522,516k (± 0.00%) ~ 3,522,256k 3,522,706k p=0.230 n=6
Parse Time 14.97s (± 0.46%) 15.09s (± 0.73%) ~ 14.93s 15.22s p=0.093 n=6
Bind Time 4.86s (± 0.45%) 4.86s (± 0.91%) ~ 4.82s 4.94s p=0.871 n=6
Check Time 94.99s (± 3.51%) 97.70s (± 4.44%) ~ 93.22s 104.00s p=0.149 n=6
Emit Time 29.98s (± 1.99%) 30.38s (± 2.75%) ~ 29.23s 31.13s p=0.471 n=6
Total Time 144.81s (± 2.70%) 148.03s (± 3.44%) ~ 142.22s 154.91s p=0.298 n=6
webpack - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 320,000 320,000 ~ ~ ~ p=1.000 n=6
Types 140,356 140,356 ~ ~ ~ p=1.000 n=6
Memory used 474,184k (± 0.02%) 474,264k (± 0.04%) ~ 474,092k 474,518k p=0.689 n=6
Parse Time 4.34s (± 0.56%) 4.30s (± 0.77%) ~ 4.26s 4.35s p=0.064 n=6
Bind Time 1.76s (± 0.98%) 1.75s (± 1.38%) ~ 1.73s 1.79s p=0.745 n=6
Check Time 20.73s (± 0.31%) 20.69s (± 0.30%) ~ 20.58s 20.74s p=0.520 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 26.82s (± 0.20%) 26.74s (± 0.29%) ~ 26.60s 26.81s p=0.054 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 667,036 667,036 ~ ~ ~ p=1.000 n=6
Types 198,508 198,508 ~ ~ ~ p=1.000 n=6
Memory used 569,731k (± 0.01%) 569,730k (± 0.04%) ~ 569,492k 569,976k p=1.000 n=6
Parse Time 5.54s (± 0.27%) 5.28s (± 0.40%) 🟩-0.26s (- 4.67%) 5.25s 5.30s p=0.005 n=6
Bind Time 1.65s (± 0.66%) 1.67s (± 0.90%) +0.02s (+ 1.01%) 1.65s 1.69s p=0.048 n=6
Check Time 25.37s (± 0.25%) 24.70s (± 1.01%) -0.67s (- 2.62%) 24.52s 25.18s p=0.005 n=6
Emit Time 0.00s 0.00s (±244.70%) ~ 0.00s 0.02s p=0.405 n=6
Total Time 32.55s (± 0.20%) 31.65s (± 0.75%) -0.91s (- 2.79%) 31.48s 32.11s p=0.005 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6
Developer Information:

Download Benchmarks

typescript-bot avatar Jun 20 '25 00:06 typescript-bot

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61901/merge:

Everything looks good!

typescript-bot avatar Jun 20 '25 01:06 typescript-bot

What about the tsconfig.json? It intentionally has comments in thousands of projects.

MartinJohns avatar Jun 20 '25 03:06 MartinJohns

This function is only used for parsing out package.json and tsbuildinfo files.

jakebailey avatar Jun 20 '25 05:06 jakebailey