Jake Bailey
Jake Bailey
That was my thought too, but the trouble is that the indicator is an AST node, because we need to be able to point diagnostics at it in some situations....
This PR is pretty broken now; I'm going to redo it, not eliminate the metadata sidecar and instead still pass stuff into the parser as an input, which should produce...
`noImplicitAny` isn't enabled by default in LS implicit projects, only `strictNullChecks` and `strictFunctionTypes`.
Kinda; in this case I'm changing it because the rebinding was very expensive (the most allocation done by the new code). For ephemeral stuff like the checker, just using fields...
I checked, and the captures I "avoided" with the `core` package changes don't matter. The functions are so small that I believe the compiler is figuring it out (either by...
I also hit this, but in https://github.com/jakebailey/pyright-action/blob/main/.ncurc.cjs. I tried to stick this in a fourslash test, but the fourslash test suite did not seem to like working with a JS...
Do you have a tsserver plugin enabled, or an extension that loaded one? Those will not work with tsgo.
Yes, so this is expected. Existing plugins for tsserver won't work in the new codebase.
I think we need more of a repro than that, unfortunately
These are the crashes from the main issue. They are two different crashes. ``` panic handling request textDocument/completion interface conversion: ast.nodeData is *ast.Token, not *ast.Identifier goroutine 164406 [running]: runtime/debug.Stack() runtime/debug/stack.go:26...