Jake Stewart

Results 5 comments of Jake Stewart

> I think we should also add a warning that if components.CloseIcon is provided, the onClose should also be provided without which components.CloseIcon is of no use. Something like [this](https://github.com/mui/material-ui/blob/master/packages/mui-lab/src/LoadingButton/LoadingButton.js#L226-L238)....

@ZeeshanTamboli in my use case I'm wanting to override the default close icon with my company's custom close icon via theme overrides. If I warned on providing CloseIcon with no...

@ZeeshanTamboli It's been three days, how long is reasonable to wait?

@mnajdova I updated this on Friday to add your recommendations. I drew inspiration from Backdrop, since most other components that have `components` and `componentsProps` are unstyled components in `@mui/base`. Let...

@mnajdova @michaldudak It's been a little while - is there anything else that needs to be done with this PR before it gets merged?