Ankit Jain

Results 47 comments of Ankit Jain

> @andrross have no objections to speed it up if you think so > > > Many will ignore the warning so keeping a longer migration window makes no difference....

> > @reta - Given we have had sometime since 2.10 was released and still thinking about 3.0, I am inclined to take this change for 3. > > +1...

@dzane17 - Please update the change description, and get this merged with help from @andrross or @reta or one of the other maintainers. Although I don't see any backport label,...

> @dzane17 @jainankitk This will break [k-NN](https://github.com/opensearch-project/k-NN/blob/main/src/main/java/org/opensearch/knn/plugin/KNNPlugin.java#L364-L375). We should update ensure k-NN gets updated before merging this change (either open an issue with a specific suggestion or create a PR...

> KNN don't use any files as NIOFS. @navneet1v - Great, thanks for confirming. Can you also create PR to remove the `additionalSettings` method from KNN plugin for 3.0? We...

@bugmakerrrrrr - While the changes look okay, I am still unsure about the impact and need of this code change. Even if not using some benchmark, having some idea of...

Also can you add entry in CHANGELOG.md, before this change can be reviewed by maintainer and merged!

@bugmakerrrrrr - Can you resolve the failing CHANGELOG verifier and codecov check while one of the maintainer reviews this PR?

@deshsidd - Thank you for sharing these results. Can you also share the query, just curious about the `query shape (wink)`? @dblock - This looks sufficient for merging the change...

@deshsidd - This PR can be discarded in favor of opensearch-project/query-insights#16, right?