Ankit Jain

Results 47 comments of Ankit Jain

I guess we can close this PR. @kaushalmahi12 - Please reopen if needed

@msfroh @ansjcy - I have similar concerns around security/validation as @sohami regarding Approach 1. Do we need to augment our existing security model to prevent `identity spoofing`?

> By default, a search without the size attribute returns 10 hits but can be scrolled to get up-to 10,000 hits. What if we only score 10,000 hits instead of...

@harshavamsi - Thank you for sharing these numbers. Look amazing! Can you provide more details on further optimizations?

> Adding documents in a single chunk in unit test to avoid multiple segments in the unit test. Is the test dependent on the number of segments? Is that the...

> The failures in flaky tests reported in different CI calls can only occur when there are multiple segments so this is more of a calculated change that we can...

> So I have iterated through the test 250 times in a loop for both scenarios (with & without my change) with 0 failures in each case. So still no...

@sandeshkr419 - Thanks for confirming the issue. Approved!

@dzane17 - Can you address conflicts by merging the main branch and revive this PR? Good time to do that since we are have started thinking about 3.0.