Jai soni
Jai soni
Screenshot for the visual appearance of left-sidebar ->
@timabbott , I added a prep commit above and rebased the other commits accordingly and made each individual commit pass the CI, can you please take a look at them...
Ahh, Thanks a lot @timabbott for suggesting to look in the history why this function was introduced if it's a noop; I looked through the commits in history and have...
@timabbott , I've updated the PR with completing the TODO added and made the node tests pass for each individual commit; Left some comments above for you to have a...
@timabbott , I've introduced af57cb4 as a preparatory commit according to what we discussed in https://github.com/zulip/zulip/pull/21102#discussion_r844509444 Let me know if this is good enough to go ahead, so that i'll...
@timabbott , I've made all the necessary changes which I was asked to do in detailed feedback of #21102. and introduced 31453ac as the major commit which would introduce collapsible...
Also @showell , @timabbott -- this PR would currently fail 2 node-tests which are -> 1.) It fails in `dispatch.js` about `user_status__set_status_emoji` event which actually calls up to `update_private_messages()` function...
@evykassirer , Thanks so much for such a detailed feedback on this PR, I've tried to address all your feedbacks and have left down comments for them and resolved the...
@andersk , I have made changes in that buggy commit and pushed it back here, it passes the CI now! Can you please merge it back ?
Huge Thanks for the review @timabbott ; - The first prep commit lgtm; - I'll go through the squash commit above and would push it's changes in 2nd commit above...