Jae Kwon
Jae Kwon
That works (only for JSON... map isn't supported for Amino:binary), but probably shouldn't be done. The output of the JSON will be: ```json { "MAP":{ "one":{ "type":"int", "value":3 }, "two":{...
Just noting that we'll want to expose the quit chan somehow. Maybe `Quit()
> @aaronc: So it seems that if you need to know the namespace at field declaration then you theoretically already know all the concrete types in that namespace. Unless I'm...
@mappum @Liamsi @keppel Thoughts?
The "types" folder is there in place of putting all the files in the root directory. Keeping project-wide common types esp for external callers in the root directory is the...
Maybe we need to break this into smaller tasks. - [ ] document how byte-length types ([]byte, [x]byte, []uint8, [x]uint8, string) are encoded (same as protobuf3)
How about we just have a standard of using cmn.Bytes for hex encoding, and not implement all the other jazz?
Relevant: https://github.com/tendermint/go-amino/issues/301 - "The binary and json were intentionally written to mirror the code structure, so this kind of translation is easy." Given the current impl, the divergence in JSON...
> This won't waste any bytes either and this is similar to the current simple prefixing. It does though... there is an extra key-length (since amino_prefix and value are now...
Just wanted to raise awareness of proposal protocolbuffers/protobuf#302 (see just above this), still championing that until someone changes my mind about the justifications there.