Jae Kwon

Results 194 comments of Jae Kwon

Agreed. Maybe we need a tag "RevisitLater" and close a bunch of PRs/issues for our peace of mind.

The main issue I see with this is that it will affect performance for every for loop iteration. By far most for loops don't suffer from this problem, so it...

My PR isn't good, but found a better way which we talked about in the call. Basically, ForStmt bodies should be wrapped with a BlockStmt and i := i if...

I agree we should start with option 2. We (AtomOne, AIB, NT, everyone) can collectively maintain both Tendermint1+AtomOne and Tendermint2 whether or not AtomOne migrates to Tendermint2. This is also...

Waiting for updates as per discussions with Ray

This PR is in a good spot because the tests pass and much of the code is written without actually creating/using any HeapItemValues. There are two minor tasks to be...

Expanding on 2 above, the next thing to try, 2.a, would be to actually copy the values to FuncValue.Captured, and uncomment the portion in preprocess.go, search for "actually uncomment".

Thank you Maxwell for the main readme description and for completing this PR.