gno icon indicating copy to clipboard operation
gno copied to clipboard

WIP fix(gnovm): add filetest for inter-realm spec

Open ltzmaxwell opened this issue 1 year ago • 2 comments

WIP: adding filetest for inter-realm spec, NOT FINAL. relate: #2743

Contributors' checklist...
  • [ ] Added new tests, or not needed, or not feasible
  • [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • [ ] Updated the official documentation or not needed
  • [ ] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [ ] Added references to related issues and PRs
  • [ ] Provided any useful hints for running manual tests

ltzmaxwell avatar Oct 16 '24 10:10 ltzmaxwell

Codecov Report

Attention: Patch coverage is 83.40249% with 40 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/realm.go 78.14% 28 Missing and 5 partials :warning:
gnovm/pkg/gnolang/store.go 0.00% 2 Missing and 1 partial :warning:
gnovm/pkg/gnolang/uverse.go 40.00% 3 Missing :warning:
gnovm/pkg/gnolang/ownership.go 98.43% 1 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Oct 16 '24 10:10 codecov[bot]

(The "review team" label was added by mistake. This PR is opened by a core dev.)

jefft0 avatar Oct 17 '24 07:10 jefft0

Check this too: https://github.com/gnolang/gno/pull/2526

moul avatar Nov 01 '24 15:11 moul

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • [ ] IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: ltzmaxwell/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Gno2D2 avatar Dec 30 '24 15:12 Gno2D2

@thehowl @ltzmaxwell

Are there any specific behavioral patterns in Gno that would be introduced by this PR? If yes, let me know, so I can document them and share with the community.

leohhhn avatar Mar 06 '25 05:03 leohhhn

@thehowl @ltzmaxwell

Are there any specific behavioral patterns in Gno that would be introduced by this PR? If yes, let me know, so I can document them and share with the community.

there is, I'll provide a short doc for you so that you can expand, as soon as possible.

ltzmaxwell avatar Mar 06 '25 06:03 ltzmaxwell

look'n

jaekwon avatar Mar 07 '25 01:03 jaekwon

close as fixed by #4037 .

ltzmaxwell avatar Apr 03 '25 05:04 ltzmaxwell