Jean de Leeuw

Results 15 comments of Jean de Leeuw

Not a problem. Take your time!

Thank you for the feedback! Unfortunately I have an import deadline coming up next week, so I am unsure whether I will be able to make adjustments according to the...

@joel-costigliola I think I can work on this to make it ready for 3.13. I'll incorporate your suggestions this weekend.

As I already noted in the comments, I am not a heavy user of buffers and therefore I agree that a review of this PR from someone with more expertise...

@mp911de First of all, thank you for your review! Secondly, I have a question I would like to ask you, because I have a feeling that I might have over-engineerd...

My apologies for not updating for a while, I plan to have all the current feedback worked in on Monday, so that we can hopefully finish this before the 3.13...

There is still one large issue that I have trouble dealing with: I am not sure how to properly implement a `isNotEmpty` method. The current implementation just checks if the...

@mp911de I think you are right. I will update the code accordingly and clearly document the limitations/edge cases in the javadoc. When the solution proves to be insufficient by users...

As you have all noticed I have been quite busy lately and as such there has not been much progress on this PR. Unfortunately this will continue for a little...

Small status update: My schedule is clearing up again, so the coming days I will pick up where I left off and then hopefully we can see it all the...