Jacob Wegner
Jacob Wegner
(I won't have reliable internet for the next week, so it might not be until next Sunday / Monday that you hear back from me)
I've got a provisional deployment done at the following URL: https://sv-ogl-pdl-refwork-53ebd0c14830.herokuapp.com/reader/urn:cts:latinLit:sec00009.sec001.perseus-eng1:1/ I've added a feature flag to the code that helps to work around some of the issues I'd documented...
Today I made some progress on the "harness" to expose the issues listed in https://github.com/scaife-viewer/scaife-viewer/issues/596#issuecomment-1697360648. Hope I can surface it soon!
(I ran the harness against https://github.com/PerseusDL/canonical-greekLit/releases/tag/0.0.6409433800 as well to help establish a baseline)
@pletcher: This is as far as I was able to get today, but I can circle back later in the week / early next week if you'd like. The [README.md...
@pletcher: I opened a PR with a few small changes needed to get Marchant deployed: https://github.com/pletcher/canonical_pdlrefwk/pull/2 I have deployed that branch to the deploy preview: https://sv-ogl-pdl-refwork-53ebd0c14830.herokuapp.com/reader/urn:cts:greekLit:viaf76387703.viaf001.perseus-eng1:1.1.1.1-1.1.1.5/ I did flip the...
`None` issue is with cRefPattern: https://github.com/PerseusDL/canonical-greekLit/blob/8930a8ddcc0882847a33c5cec98a64796f7c2d5c/data/tlg0012/tlg001/tlg0012.tlg001.perseus-grc2.xml#L59 https://github.com/pletcher/canonical_pdlrefwk/blob/6ed59ffa60dda99062ce3f8a712b445f9cdc4554/data/viaf76387703/viaf001/viaf76387703.viaf001.perseus-eng1.xml#L33C3-L33C3
(Sounds right to me...if we don't want a version to be shown on scaife.perseus.org, we should remove it from the source repo)
@dasmiq I had tried to reply here yesterday, but it looks like it didn't go through...sorry! You're correct that the current endpoints only support the "top level". The GraphQL API...
@dasmiq: The new endpoint is available for preview here: https://scaife-dev.perseus.org/library/urn:cts:greekLit:tlg0081.tlg001.perseus-grc2/cts-api-xml/reffs/?level=1 https://scaife-dev.perseus.org/library/urn:cts:greekLit:tlg0081.tlg001.perseus-grc2:1/cts-api-xml/reffs/?level=1 It should work just as the old `GetValidReff` request on scaife-cts.perseus.org. I will get it "promoted" to scaife.perseus.org early...