Jacob
Jacob
FWIW I think that this change would also help make this compatible with [`ember-cli-typescript`](https://github.com/typed-ember/ember-cli-typescript), i.e. prevent a message like the following (https://github.com/typed-ember/ember-cli-typescript/pull/1046) when trying to generate `missing-message.js` from `missing-message.ts` ```...
FWIW, I've been using yarn's selective dependency option to force the postcss packages to upgrade (AFAIK the only breaking stuff was dropping old versions, which don't cause problems for me)...
This seems to be coming from https://github.com/ember-decorators/ember-decorators/blob/84414eb0c4497d228ecf4622cae2f4120c101d79/packages/object/addon/computed.js#L705 https://github.com/ember-decorators/ember-decorators/blob/84414eb0c4497d228ecf4622cae2f4120c101d79/packages/object/addon/-private/util.js#L65 https://github.com/ember-decorators/ember-decorators/blob/84414eb0c4497d228ecf4622cae2f4120c101d79/packages/object/addon/-private/util.js#L116-L120 https://github.com/ember-decorators/ember-decorators/blob/84414eb0c4497d228ecf4622cae2f4120c101d79/packages/utils/addon/computed.js#L51 since the calling function didn't provide `importDesc`. A band-aid could be to check that `importDesc` is truthy before displaying it...
Is the suggested replacement code `import { /* legacy macros here */ } from '@ember/object/computed';`? The docs are either out of date or in disagreement with this as they show...
Alternatively, the `event` could be passed to the `onClick` handler so that the consumer can decide whether to `preventDefault`, `stopPropagation`, etc. as needed.
Ha, just saw this (after mentioning in #311), but you are right. In fact, now in Ember 4.x injecting like that no longer works, so I've suggested removing this part...
I believe this is fixed in 8.x (i.e. #314 listed in https://github.com/mansona/ember-cli-notifications/blob/master/CHANGELOG.md#800--2022-01-28)
@frinyvonnick Are you still seeing this in v7.x? Today I tried the mainline version of this instead of https://github.com/mansona/ember-cli-notifications/pull/270 and links seem to work now (not sure if this is...
Hmm, I suppose a [`window.open`](https://developer.mozilla.org/en-US/docs/Web/API/Window/open) [`onclick`](https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onclick) hack isn't going to cut it 😉 ```html Awful hack ``` (Seems like I am always finding myself [writing ugly hacks](https://github.com/mansona/ember-cli-notifications/issues/274#issue-616372257)...maybe someday I will...