ember-cli-notifications icon indicating copy to clipboard operation
ember-cli-notifications copied to clipboard
verified publisher icon mansona

fix: don't consume clicks when no onClick given (fix #274)

Open jacobq opened this issue 3 years ago • 1 comments

To avoid the problems described in #269 and #274 (that #270 was supposed to fix) this PR proposes making the handleOnClick function inert when @onClick is not provided.

Demo: https://github.com/jacobq/ecm-clickProblem

jacobq avatar Mar 11 '22 19:03 jacobq

Alternatively, the event could be passed to the onClick handler so that the consumer can decide whether to preventDefault, stopPropagation, etc. as needed.

jacobq avatar May 26 '22 20:05 jacobq