jackylee
jackylee
Using `LargeStringHashMap` instead of `StringHashMap`, which actually uses `LargeBinaryBuilder` to append string values, works with me for this problem.
It also failed when then is an aggragation, which does not support WSCG, before SMJ. Here is an example. ``` ColumnarSortMergeJoin [q#5], [q#671], Inner, false :- ColumnarSort [q#5 ASC NULLS...
> Thanks for debugging, the issue is due to some legacy codegen check in SortMergeJoin - will do clean ups @zhouyuan Thanks for reply. I also find compile failed cases...
@PedroRossi Yeap, this is a good suggestion. I will check it out.
@PedroRossi This is a great idea, but it need a lot of changes. I will submit this in a new patch, which we can discuss in it.
@itamarst This patch is mainly used to control throwing exception in sqlqueries. There will be another patch to handle the problem @PedroRossi talked with me.
Could you review this pr? @gggrace14 cc @PHILO-HE @rui-mo
> @jackylee-ch does the fix impact the configurations? Looks without the fix it's configured as a single file path, with the fix we can configure with multiple paths with ","...
cc @PHILO-HE @rui-mo