Jack Wilsdon comments

Results 61 comments of


Jack Wilsdon

Add coercing to properties to ensure type safety (`disabled = undefined || null` is not supported)

Seems like the behaviour was actually changed in v1.1.0. [Here's a playground using 1.0.1](https://lit.dev/playground/#project=W3sibmFtZSI6Im15LWV4YW1wbGUudHMiLCJjb250ZW50IjoiaW1wb3J0IHtodG1sLCBjc3MsIExpdEVsZW1lbnR9IGZyb20gJ2xpdCc7XG5pbXBvcnQge2N1c3RvbUVsZW1lbnR9IGZyb20gJ2xpdC9kZWNvcmF0b3JzLmpzJztcbmltcG9ydCAnQG1hdGVyaWFsL3dlYkAxLjAuMS9zbGlkZXIvc2xpZGVyJztcblxuQGN1c3RvbUVsZW1lbnQoJ215LWV4YW1wbGUnKVxuZXhwb3J0IGNsYXNzIE15RXhhbXBsZSBleHRlbmRzIExpdEVsZW1lbnQge1xuICBzdGF0aWMgc3R5bGVzID0gY3NzYFxuICAgIGlucHV0IHtcbiAgICAgIGRpc3BsYXk6IGJsb2NrO1xuICAgIH1cbiAgYDtcbiAgXG4gIHJlbmRlcigpIHtcbiAgICByZXR1cm4gaHRtbGBcbiAgICAgIDxtZC1zbGlkZXIgLmRpc2FibGVkPSR7bnVsbH0-PC9tZC1zbGlkZXI-XG4gICAgICA8bWQtc2xpZGVyIC5kaXNhYmxlZD0ke3VuZGVmaW5lZH0-PC9tZC1zbGlkZXI-XG4gICAgICA8aW5wdXQgdHlwZT1cInRleHRcIiAuZGlzYWJsZWQ9JHtudWxsfSAvPlxuICAgICAgPGlucHV0IHR5cGU9XCJ0ZXh0XCIgLmRpc2FibGVkPSR7dW5kZWZpbmVkfSAvPlxuICAgIGA7XG4gIH1cbn1cbiJ9LHsibmFtZSI6ImluZGV4Lmh0bWwiLCJjb250ZW50IjoiPCFET0NUWVBFIGh0bWw-XG48aGVhZD5cbiAgPHNjcmlwdCB0eXBlPVwibW9kdWxlXCIgc3JjPVwiLi9teS1leGFtcGxlLmpzXCI-PC9zY3JpcHQ-XG48L2hlYWQ-XG48Ym9keT5cbiAgPG15LWV4YW1wbGU-PC9teS1leGFtcGxlPlxuPC9ib2R5PlxuIn0seyJuYW1lIjoicGFja2FnZS5qc29uIiwiY29udGVudCI6IntcbiAgXCJkZXBlbmRlbmNpZXNcIjoge1xuICAgIFwibGl0XCI6IFwiXjMuMC4wXCIsXG4gICAgXCJAbGl0L3JlYWN0aXZlLWVsZW1lbnRcIjogXCJeMi4wLjBcIixcbiAgICBcImxpdC1lbGVtZW50XCI6IFwiXjQuMC4wXCIsXG4gICAgXCJsaXQtaHRtbFwiOiBcIl4zLjAuMFwiXG4gIH1cbn0iLCJoaWRkZW4iOnRydWV9XQ) [And one using 1.1.0](https://lit.dev/playground/#project=W3sibmFtZSI6Im15LWV4YW1wbGUudHMiLCJjb250ZW50IjoiaW1wb3J0IHtodG1sLCBjc3MsIExpdEVsZW1lbnR9IGZyb20gJ2xpdCc7XG5pbXBvcnQge2N1c3RvbUVsZW1lbnR9IGZyb20gJ2xpdC9kZWNvcmF0b3JzLmpzJztcbmltcG9ydCAnQG1hdGVyaWFsL3dlYkAxLjEuMC9zbGlkZXIvc2xpZGVyJztcblxuQGN1c3RvbUVsZW1lbnQoJ215LWV4YW1wbGUnKVxuZXhwb3J0IGNsYXNzIE15RXhhbXBsZSBleHRlbmRzIExpdEVsZW1lbnQge1xuICBzdGF0aWMgc3R5bGVzID0gY3NzYFxuICAgIGlucHV0IHtcbiAgICAgIGRpc3BsYXk6IGJsb2NrO1xuICAgIH1cbiAgYDtcbiAgXG4gIHJlbmRlcigpIHtcbiAgICByZXR1cm4gaHRtbGBcbiAgICAgIDxtZC1zbGlkZXIgLmRpc2FibGVkPSR7bnVsbH0-PC9tZC1zbGlkZXI-XG4gICAgICA8bWQtc2xpZGVyIC5kaXNhYmxlZD0ke3VuZGVmaW5lZH0-PC9tZC1zbGlkZXI-XG4gICAgICA8aW5wdXQgdHlwZT1cInRleHRcIiAuZGlzYWJsZWQ9JHtudWxsfSAvPlxuICAgICAgPGlucHV0IHR5cGU9XCJ0ZXh0XCIgLmRpc2FibGVkPSR7dW5kZWZpbmVkfSAvPlxuICAgIGA7XG4gIH1cbn1cbiJ9LHsibmFtZSI6ImluZGV4Lmh0bWwiLCJjb250ZW50IjoiPCFET0NUWVBFIGh0bWw-XG48aGVhZD5cbiAgPHNjcmlwdCB0eXBlPVwibW9kdWxlXCIgc3JjPVwiLi9teS1leGFtcGxlLmpzXCI-PC9zY3JpcHQ-XG48L2hlYWQ-XG48Ym9keT5cbiAgPG15LWV4YW1wbGU-PC9teS1leGFtcGxlPlxuPC9ib2R5PlxuIn0seyJuYW1lIjoicGFja2FnZS5qc29uIiwiY29udGVudCI6IntcbiAgXCJkZXBlbmRlbmNpZXNcIjoge1xuICAgIFwibGl0XCI6IFwiXjMuMC4wXCIsXG4gICAgXCJAbGl0L3JlYWN0aXZlLWVsZW1lbnRcIjogXCJeMi4wLjBcIixcbiAgICBcImxpdC1lbGVtZW50XCI6IFwiXjQuMC4wXCIsXG4gICAgXCJsaXQtaHRtbFwiOiBcIl4zLjAuMFwiXG4gIH1cbn0iLCJoaWRkZW4iOnRydWV9XQ) Note that the second slider is enabled in 1.0.1 but not 1.1.0.