jakevin

Results 58 comments of jakevin

It didn't work. like those. [Test PR](https://github.com/jackwener/Readings-in-Database-Systems-5th-CN/pull/14) [Test issue](https://github.com/jackwener/Readings-in-Database-Systems-5th-CN/issues/15)

The current way of using it is like touching the elephant by the blind, I think it’s not very good

action-add-lable didn't work. [link](https://github.com/jackwener/Readings-in-Database-Systems-5th-CN/runs/4724473369?check_suite_focus=true)

The issue is interesting, I'm willing to take this task up.

@menghanl After I read code and your instruction, I think the solution is to remove `net.ParseIP` in `formatIP` but remain `net.ParseIP` in `parseTarget`. Is this right? https://github.com/grpc/grpc-go/blob/a42567fe92f005c47e60146bdbb0d5f7fc232219/internal/resolver/dns/dns_resolver.go#L364 https://github.com/grpc/grpc-go/blob/a42567fe92f005c47e60146bdbb0d5f7fc232219/internal/resolver/dns/dns_resolver.go#L387

It's not enough to remove `net.ParseIP`, because address will be not verified. We could still use `ParseIP` for verifying if it is in high version. [parseIPv6](https://github.com/golang/go/blob/aa0dda767a9a31c6b0b49a665f0d059ebfed8e1c/src/pkg/net/ip.go#L490) support literal IPv6

OMG,the solution above is wrong. The solution is removing the IP resolver , and `let the default go DNS resolver handle everything.` However, `customAuthorityResolver` call `formatIP` and `parseTarget`. There is...

Yes, I notice that `dns:///[fe80::1ff:fe23:4567:890a%eth2]:8080` is supported instead of `net.Dial("dns:///fe80::1ff:fe23:4567:890a%eth2:8080") `

> Sadly it does not even work with the `build-helper-maven-plugin` plugin. VSC refuses to see the generated sources and won't compile. In my case I have a nested Project pom...