doris icon indicating copy to clipboard operation
doris copied to clipboard

Published 20 hours ago • verified publisher icon apache

[refactor](fe-core/src/test/catalog): refactor and replace use NIO

Open dinggege1024 opened this issue 1 year ago • 5 comments

Proposed changes

Issue Number: #12780

Problem summary

refactor and replace use NIO

Checklist(Required)

  1. Does it affect the original behavior:
    • [✅] Yes
    • [ ] No
    • [ ] I don't know
  2. Has unit tests been added:
    • [ ] Yes
    • [ ] No
    • [✅] No Need
  3. Has document been added or modified:
    • [ ] Yes
    • [ ] No
    • [✅] No Need
  4. Does it need to update dependencies:
    • [ ] Yes
    • [✅] No
  5. Are there any changes that cannot be rolled back:
    • [ ] Yes (If Yes, please explain WHY)
    • [✅] No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

dinggege1024 avatar Sep 21 '22 09:09 dinggege1024

Why changing this? Is there any explaination?

morningman avatar Sep 21 '22 10:09 morningman

Why changing this? Is there any explaination?

Updated in proposed Changes

dinggege1024 avatar Sep 21 '22 10:09 dinggege1024

Thanks @dinggege1024

jackwener avatar Sep 21 '22 12:09 jackwener

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Sep 21 '22 14:09 github-actions[bot]

PR approved by anyone and no changes requested.

github-actions[bot] avatar Sep 21 '22 14:09 github-actions[bot]

Why changing this? Is there any explaination?

dinggege1024 avatar Sep 24 '22 13:09 dinggege1024

Thanks @dinggege1024

jackwener avatar Sep 26 '22 08:09 jackwener

PR approved by at least one committer and no changes requested.

github-actions[bot] avatar Sep 26 '22 08:09 github-actions[bot]