Jack Robison comments

Repositories
Issues
Comments

Results 5 comments of


                                            Jack Robison

Detect if internet connection is through a carrier grade NAT (starlink)

@shyba pointed out a user on an isp with CGNAT who routes through a remote VPN will be connectable and would be a false positive by this metric.

UPnP configuration of port mapping do not work with router Sagemcom F@st3890V3

Thanks for reporting this! I'll try to reproduce in a test using your debugging info

Invalid continuation byte

This device has a modelNum of `ð_ð`

HashXHistoryPrefixRow issue with endianness of TxNums written to DB

This is a consequence of using an `array.array('I')`, which uses the native endianness. And I think it's actually worse - docs say `It can be 16 bits or 32 bits...

lbry-sdk suite: test_es_sync_utility: AssertionError: 217 != 218

Thanks for pointing this out, this appears to be a race condition in the tests (it is not a vulnerability, just a bug) - these commits are working towards fixing...