Jack O'Connor

Results 202 comments of Jack O'Connor

Same issue here on MacOS Sierra 10.12.1

Hi @jdc0589 did this ever get merged in? Are you still waiting for feedback? If so, how would I go about installing JsFormat from that specific branch? Thanks for your...

Hmm fair enough. I would be open to a PR to add a new initialisation option `autoTitle`, which defaults to true, but if set to false will not set any...

Thanks for putting this together. You're actually the second person to raise this issue. I responded to the last one here: https://github.com/jackocnr/intl-tel-input/pull/1175#issuecomment-774652866 What do you think?

Thanks for doing that :) Yes I think this example might work: https://w3c.github.io/aria-practices/examples/listbox/listbox-collapsible.html What do you think? If you agree, I'd be open to a pull request to update our...

Good catch. I would welcome a PR to address this. I wasn't sure about the idea of making the selected flag un-tabbable tho - I guess it should behave the...

Have you tried the hiddenInput option? That will get you the full number including intl dial code. But note that this only works with valid numbers.

That's not a valid number. The library we use libphonenumber can only put together the full number if it's valid. So you either need to do client side validation before...

> I tried it with a valid number and have the same result. This shouldn't happen. What was that valid number? Having thought about it though, I do think that...

Yeah I agree. I'd welcome a pull request to fix this. From a quick glance, I think the issue is in the formatNumber method in utils.js.