Jack Francis

Results 586 comments of Jack Francis

Hi Harry, we could be open to that. Could you provide an example of what you'd like to do in addition to (or instead of) the normal k8s "drain node"...

That helps, thanks @harrytang! I'll think about how we might put something like this together, stay tuned!

+1, as a dev would love to be able to more easily identify that a test failure was caused by incorrect `Eventually` usage.

should we close this based on https://github.com/kubernetes-sigs/dra-example-driver/pull/50 ?

cc @nojnhuh @ritazh

cc @JohnRusk Do you have any thoughts on this change?

> The only risk I can think of would be if in fact this statement wasn't _always_ correct: "since it works with non-AKS Azure clusters (such as CAPZ) as well"....

/remove-lifecycle rotten

The code returns the first "non-undefined" `drainability.Status` result that it receives as it enumerates through the set of drainability rules: - https://github.com/kubernetes/autoscaler/blob/cluster-autoscaler-1.34.1/cluster-autoscaler/simulator/drainability/rules/rules.go#L95-L113 Not sure that the order defined here is...