dra-example-driver icon indicating copy to clipboard operation
dra-example-driver copied to clipboard

update deployment for 1.31

Open pohly opened this issue 1 year ago • 8 comments

https://github.com/kubernetes/kubernetes/pull/125163 is making the drivers responsible for publishing ResourceSlices and getting the ResourceClaim. The example driver needs to be updated to work with that change.

Furthermore, we need to demonstrate how apiserver access can be limited. See https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/deploy/example/plugin-permissions.yaml.

We also should document that deployments are expected to limit access to admin access as in https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/deploy/example/admin-access-policy.yaml

pohly avatar Jun 06 '24 14:06 pohly

Some relevant documentation:

  • https://kubernetes.io/docs/reference/access-authn-authz/service-accounts-admin/#additional-metadata-in-pod-bound-tokens (provides the correlation with the node, if I am not mistaken)

pohly avatar Jun 06 '24 14:06 pohly

/assign @carlory

pohly avatar Jun 06 '24 14:06 pohly

/unassign

For some reason, I may not have time to complete this task. If I am free and the task still needs volunteers, I will come back to claim it. sorry for the delay @pohly

carlory avatar Jul 12 '24 10:07 carlory

If someone raises a PR, I am very happy to review together

carlory avatar Jul 12 '24 10:07 carlory

should we close this based on https://github.com/kubernetes-sigs/dra-example-driver/pull/50 ?

jackfrancis avatar Aug 14 '24 18:08 jackfrancis

Yes. Closed by https://github.com/kubernetes-sigs/dra-example-driver/pull/53

klueska avatar Aug 15 '24 11:08 klueska

Actually, let's reopen this, as not all all of the criteria that @pohly mentions in the issue has been fulfilled. That is to say that basic support for 1.31 has been merged (i.e. it is functional), but it doesn't check all of the boxes that @pohly has for being done the "right" way.

klueska avatar Aug 16 '24 13:08 klueska

I agree, let's add at least the RBAC rules. I've updated the description with more recent links.

pohly avatar Aug 19 '24 07:08 pohly

/assign

pohly avatar Oct 14 '24 09:10 pohly

/unassign /assign @bart0sh

pohly avatar Oct 14 '24 09:10 pohly

/wg device-management /milestone v1.32

pohly avatar Oct 14 '24 09:10 pohly

cc @nojnhuh @ritazh

jackfrancis avatar Oct 14 '24 15:10 jackfrancis