Jack Francis

Results 586 comments of Jack Francis

@nclaeys I'm planning to demo this and propose to the community next Monday Jan 22 at 16:00 Poland time zone (details [here](https://github.com/kubernetes/community/blob/master/sig-autoscaling/README.md#meetings)) if you'd like to attend and add feedback

/assign @elmiko for a first pass to make sure I'm doing something sane here

On the other hand maybe just passing in `clusterNamespace` in the auto discovery config for Cluster API doesn't work like I think it does? On a cluster I have running...

Nevermind! I was using the wrong `clusterapi` key for `--node-group-auto-discovery`, should be `namespace=` not `clusterNamespace=`

not sure why the helm docs CI is complaining (I did make changes there but I think that should be allowed)

@gjtempleton thanks for the pro tip, done!

@gjtempleton I wonder if this change in my PR that merged yesterday (which passed CI) is throwing a wrench in this PR? - https://github.com/kubernetes/autoscaler/pull/5768/files#diff-d0c14bc33196b8f56c06b62d79b3f92cd75f94279dedecb4f3982493eafa9054

@mwielgus rebased, thx for the nudge @gjtempleton can't seem to figure out how to make `helm-docs` happy on this one...

@gjtempleton `brew install norwoodj/tap/helm-docs && helm-docs` did the trick :)