Jack Francis

Results 586 comments of Jack Francis

/assign @gjtempleton for charts change

You'll want to cut a new chart version (Chart.yaml) w/ these changes. I'd say that this warrants a minor bump.

@Jont828 you'll need to bump the chart version (which will mean whichever of your PRs merges first will conflict with the other one that also needs a chart version bump,...

/test pull-cluster-autoscaler-e2e-azure

/test pull-cluster-autoscaler-e2e-azure

Seems like something got lost here? I only see a fraction of the original changes.

@MaciekPytel @x13n thanks for your notes. I'm 100% aligned on making this cloud provider-reusable and implementing this in partnership w/ at least one other provider. I'll reserve some more cycles...

@nclaeys I'm working on implementing VMSS deallocate for the azure provider here: https://github.com/kubernetes/autoscaler/pull/6202 I'd love your feedback on the implementation and UX!