jackeykong

Results 4 comments of jackeykong

I also found a small error in the Multi-threaded Sending section of the readme.md file. `hffix::message_reader::const_iterator i = std::find(r.begin(), r.end(), hffix::tag_equal(hffix::tag::MsgSeqNum)); if (i != r.end()) { std::snprintf(const_cast(i->begin()), i->size(), "%.8i", next_sequence_number++);...

> Hi, thanks for opening this issue. > > > 1. On Windows, there is no 'ssize_t' type. > > You're right, `ssize_t` is not standard and we shouldn't use...

> > But, `std::string_view::begin` and `std::string_view::end` return `std::basic_string_view` instead of `const char*` > > They return a `std::basic_string_view::const_iterator` which will be type `const char *`. Or is it not type...

Yes, I will be happy to do PR. just modify as follows : `void push_back_string(int tag, std::string_view s) { push_back_string(tag, s.data(), s.data() + s.length()); }`