Jaap van Otterdijk
Jaap van Otterdijk
Hi, To get started, I think you didn't have a look at the code in this method. If you did, you would have noticed that this method has some recursion....
What is the status of this pr? I would like to start working on php8 compatibility. But this large move of files makes me feel that I have to wait...
@asgrim can this one be closed? It looks like you already provided a patch for this issue?
In that case I will dive into this to see if it can be resolved
Feel free to make a pr :blush:
The issue here is that php is somehow interpreting files from top to bottom, we are simply parsing a file in the same way but are trying to map that...
The problem here is that we are using php's reflection component to get the location of the property. At runtime the traits do not exist anymore so we cannot resolve...
Thanks a lot for this PR. I do get what you are trying to achieve here. But I do not like the extra complexity it takes to get this all...
Thanks for this PR, You are introducing quite a lot of other things in this PR than just a fix for this issue you found. Please remove those. And make...
``` $codec = new OrderedTimeCodec( (new UuidFactory())->getUuidBuilder() ); $queryBuilder = $this->createQueryBuilder('e'); $queryBuilder->where( $queryBuilder->expr()->in( 'e.id', ':ids' ) ); $queryBuilder->setParameter('ids', array_map(function(UuidInterface $uuid) use ($codec) { return $codec->encodeBinary($uuid); }, $ids)); ``` This seems...