GraphViz icon indicating copy to clipboard operation
GraphViz copied to clipboard

Issue #33: Fix directed edges

Open drupol opened this issue 6 years ago • 4 comments

This PR:

  • [x] Fix bug #33
  • [x] Adds 2 interfaces.
  • [x] Adds 1 trait.
  • [ ] Update code style.
  • [ ] Adds .editorconfig configuration file.
  • [ ] Adds .gitattributes file.
  • [ ] Use Grumphp for pre-commit checks.

drupol avatar Sep 05 '19 18:09 drupol

Thanks for this PR,

You are introducing quite a lot of other things in this PR than just a fix for this issue you found. Please remove those. And make this a clean PR to fix the issue. Any additional changes can be discussed but should not be in this pr.

It is perfectly ok if you are using tools to improve your own code base, but I don't want them in this repo right now. If we want to introduce Grumphp for example I want to use it organisation wide and define how to introduce it. Not just in a single repo, without any additional that is organisation wide used.

jaapio avatar Sep 07 '19 12:09 jaapio

Allrighty, removed all the unrelated stuff.

drupol avatar Sep 08 '19 20:09 drupol

Waiting for your feedback @jaapio .

drupol avatar Sep 08 '19 20:09 drupol

Is there any chance this is moving forward - and changes into master?

dereuromark avatar Oct 04 '22 17:10 dereuromark