GraphViz
GraphViz copied to clipboard
Issue #33: Fix directed edges
This PR:
- [x] Fix bug #33
- [x] Adds 2 interfaces.
- [x] Adds 1 trait.
- [ ] Update code style.
- [ ] Adds
.editorconfigconfiguration file. - [ ] Adds
.gitattributesfile. - [ ] Use Grumphp for pre-commit checks.
Thanks for this PR,
You are introducing quite a lot of other things in this PR than just a fix for this issue you found. Please remove those. And make this a clean PR to fix the issue. Any additional changes can be discussed but should not be in this pr.
It is perfectly ok if you are using tools to improve your own code base, but I don't want them in this repo right now. If we want to introduce Grumphp for example I want to use it organisation wide and define how to introduce it. Not just in a single repo, without any additional that is organisation wide used.
Allrighty, removed all the unrelated stuff.
Waiting for your feedback @jaapio .
Is there any chance this is moving forward - and changes into master?