James Gaboardi
James Gaboardi
* drop Python 3.10 from testing matrix * update * documentation * min reqs * any reason to keep 3.10? * xref https://github.com/pysal/pysal/issues/1373
* add testing against Python 3.13 * https://github.com/pysal/pysal/issues/1372
* The [`topo.ipynb`](https://github.com/pysal/esda/blob/main/notebooks/topo.ipynb) uses the `'naturalearth_lowres'` from `geopandas.datasets` * `geopandas.datasets` is not longer a thing, so we could use it's successor – `geodatasets` * but `'naturalearth_lowres'` is not available through...
* cell 38 in [`notebooks/Spatial Autocorrelation for Areal Unit Data.ipynb`](https://github.com/pysal/esda/blob/c48ea119b6053ba349de35b4a19b3b717e484cf3/notebooks/Spatial%20Autocorrelation%20for%20Areal%20Unit%20Data.ipynb) fails with `numba` installed * (passes without `numba` installed) * [`moran.Moran_Local`](https://github.com/pysal/esda/blob/c48ea119b6053ba349de35b4a19b3b717e484cf3/esda/moran.py#L1142) calling `crand.crand()` -> [`compute_chunk()`](https://github.com/pysal/esda/blob/c48ea119b6053ba349de35b4a19b3b717e484cf3/esda/crand.py#L230) ``` --------------------------------------------------------------------------- TypingError Traceback (most...
What should we do with the `tools/moran_*` noebooks? * nothing – simply keep in `tools/` * keep in `tools/` but update (and keep updated) - (add `pygeoda` & `geosnap` to...
* there are two tests named `test_Kernel_Smoother_tabular` in `test_smoothing.TestKernel_AgeAdj_SM` * [first](https://github.com/pysal/esda/blob/d711f9fa205cbe5e34dcb63ead7e99b3d6ab19a8/esda/tests/test_smoothing.py#L419) * [second](https://github.com/pysal/esda/blob/d711f9fa205cbe5e34dcb63ead7e99b3d6ab19a8/esda/tests/test_smoothing.py#L509) * the first is broken, but was never being run due to being overwritten by the second...
The line below is throwing a deprecation warning from `sklearn`: https://github.com/pysal/esda/blob/cabd67af46f123e6fffbaae1b66f765031cee065/esda/geary_local_mv.py#L82 ``` esda/tests/test_local_geary_mv.py::TestGearyLocalMV::test_local_geary_mv[W] esda/tests/test_local_geary_mv.py::TestGearyLocalMV::test_local_geary_mv[Graph] /home/runner/micromamba/envs/test/lib/python3.12/site-packages/sklearn/utils/deprecation.py:132: FutureWarning: 'force_all_finite' was renamed to 'ensure_all_finite' in 1.6 and will be removed in 1.8. ```
* Gauging interest in (attempting to) migrate [`splot`'s `bokeh` stuff](https://github.com/pysal/splot/blob/b8361cb5f4685d0945e08cbf9172ba701ce57c44/splot/_viz_bokeh.py) * big caveat is that [it includes `spreg` functionality](https://github.com/pysal/splot/blob/b8361cb5f4685d0945e08cbf9172ba701ce57c44/splot/_viz_bokeh.py#L414-L415) * xref * https://github.com/pysal/splot/issues/188#issuecomment-2571752445 * https://github.com/pysal/esda/pull/360
Testing against Python 3.13 across federation * xref #1340 ------------------------ * [ ] `pysal/pysal` – * [x] `pysal/access` – https://github.com/pysal/access/pull/62 * [x] `pysal/esda` – * [x] `pysal/giddy`- https://github.com/pysal/giddy/pull/237 * [x]...
* remove testing against Python 3.10 across federation * predicated on #1372 * any packages where we should be keeping 3.10? * cc @sjsrey @knaaptime @gegen07 @martinfleis ---------------------------------- * [...