Jelte Lagendijk

Results 17 comments of Jelte Lagendijk

@thomaslombart I checked the build log... It only fails on the contributor `kidonng`, cannot find this user ``` ...Invalid contributor "kidonng". Error: Not found (RequestID: da466030-907b-4d2f-9827-6652041a41e9) ``` The code itself...

@SeDemal I don't think the internal one changes based on the external? As far as I know the only URL that is exposed is the external url. ~I did leave...

@ajnart based on the comment from @SeDemal I updated the functionality. It now includes the protocol... - You can now set the external url to `[homarr_base]` and it will replace...

@ajnart will add a tooltip first, then the docs :) 👍

~It does use the translations, do I need to translate it myself for all the other languages? (I'll probably have to use Google Translate or something 😬)~ Edit: added the...

Sorry, how does this break the system? The keys are there per language, I just added them to each of them...

@SeDemal done. It might be a good idea to document it somewhere (for example in the contribution guide) that you can't add translations.

Updated the functionality based on feedback from @SeDemal. I'm not completely satisfied with the tooltip (it contains a lot of text), but it does work as expected. Here's the updated...

> Can you revert your changes to `.vscode/settings.json` and `data/configs/default.json`? Beside this this looks awesome ❤️‍🔥, thanks for your contribution 😃 @Meierschlumpf didn't notice I committed those changes as well......