John Hendricks
John Hendricks
`Timestamp.tzinfo` has already been resolved here: #61100
Taking the following: -i "pandas.Timestamp.max PR02" \ -i "pandas.Timestamp.min PR02" \ -i "pandas.Timestamp.resolution PR02" \
@glemaitre @adrinjalali I've searched the entire project and the table below summarizes my findings. Do you agree with my recommendations? I believe methods that use both `_check_feature_names` and `_check_n_features` should...
#31775 to be merged before ready for review
@lucyleeow thanks for the recommendations! I agree with all of them and have updated the PR accordingly :)
I added a common test for all zero sample weights, but came across some edge cases that I need to investigate further. If you run `pytest sklearn/tests/test_common.py::test_check_all_zero_sample_weights_error`, the following estimators...
> I added a common test for all zero sample weights, but came across some edge cases that I need to investigate further. > > If you run `pytest sklearn/tests/test_common.py::test_check_all_zero_sample_weights_error`,...
@lucyleeow I think we're ready for final reviews before merging, but before we do that I'm going to add you as a co-author given you were the one who outlined...
> @j-hendricks just checking if you are still interested in working on this? @lucyleeow Yup! Working on it right now