Irina Truong
Irina Truong
We explicitly strip comments before passing the SQL on to psycopg2: https://github.com/dbcli/pgcli/blob/c65495716d9fa6914f689d410d3c737d7661053d/pgcli/pgexecute.py#L433 What's the use case for keeping the comments?
TIL. I believe that `psycopg2` can execute SQL queries with comments in them, it should be easy enough to remove comment stripping in a branch and see what happens. I...
I filed an issue in click: https://github.com/pallets/click/issues/1956.
Closed as duplicate of https://github.com/dbcli/pgcli/issues/1200.
pgcli does not support all meta-commands ("backslash commands") that exist in psql. `\?` will display all supported pgcli commands. I can leave this open as feature request - but it's...
@amjith I thought we aren't displaying status in CSV [intentionally](https://github.com/dbcli/pgcli/pull/1173), because it was breaking `pspg` pager. Can you explain why we need this now? Edited: Got it, I now see...
@amjith I noticed that in this comment: https://github.com/dbcli/pgcli/issues/1326#issuecomment-1162472608 the author says that even with this cnange, `pgcli` still doesn't behave the right way when displaying stderr, while litecli does. Do...
Unit tests are failing with a unicode error there in `tests/test_pgexecute.py`. Are you able to run them locally (running `py.test` in pgcli directory)?
@quezak This PR has a couple of outstanding questions, and needs a rebase on master. We've heard nothing from @gma2th in a long time, and I don't think they are...
Hi @vanviegen , I see your PR's tests are failing on `test_virtual_database`. We have some special handling for `pgbouncer` database, and I suspect transactions wouldn't be supported in that, so...