Irina Truong

Results 126 comments of Irina Truong

Hey @dkuku, thank you for the PR! I like the idea. However, implementation may appear to be a bit more complicated that this POC. You only handle variations of `pattern`...

@dkuku I can't say for sure where the suffix is used, but those queries were reverse-engineered running `psql` with `-E`. That way, it shows you queries that it runs on...

@dkuku > I understand it may not be used at all ? I could not find it in the code. I think you're right, the positioning of the query fields...

Hey @dkuku , thanks for your work. I didn't forget about this PR, but I need a good chunk of time to review it. It's a lot. In the meantime,...

> I'm currently comparing the output of my changes, old version and psql and I see there are some differences between our and psql - I will try to align...

That's an interesting feature request! I can see how it might be useful if you work with large blobs of text. I'll give it some thought.

Hi @tfh-cri , You're correct, the code for the named queries is here: https://github.com/dbcli/pgspecial/blob/main/pgspecial/namedqueries.py https://github.com/dbcli/pgspecial/blob/main/pgspecial/iocommands.py You'd have to change this function to handle your new parameter type: https://github.com/dbcli/pgspecial/blob/f05518edb17d89a8d1ecdc02c470dbc8a6c124cd/pgspecial/iocommands.py#L179 You're welcome...

@dvarrazzo @amjith We're using `postgres:10` image in CI, and in fact, the official Postgres support for it [ended in November 2022 (2 months ago)](https://www.postgresql.org/support/versioning/), so we should switch to 11...

Nice. :) If this is useful to you, it's useful to other people.

@jonathanslenders can you advise?