Iaroslav Zeigerman

Results 22 comments of Iaroslav Zeigerman

Hey @sharmahemlata! Sorry to hear that you run into this issue. We actually already have a mechanism in place which automatically splits the code into sub-methods based on the size...

To summarize I suggest the following: - Try reducing the `ast_size_per_subroutine_threshold ` value to eg. 3000 while keeping the `ast_size_check_frequency` value unchanged. - If the previous change doesn't work, try...

Sorry to hear this, @sharmahemlata. Perhaps you can provide some steps to reproduce the issue?

@sharmahemlata this is great, thanks a lot for sharing! I'll take a look and will come back to you after that

Hey @fkajzer! Sorry you run into this issue. Unlike in the #297 issue, splitting code into subroutines doesn't help in your case, because the `too many constants` error is a...

Hey @Aulust! I think this change is great and will be an amazing addition to the library. Any chance you plan to finish the work on this PR?

Hi @skjerns ! Thanks for the feedback, I'm very glad to hear that you find `m2cgen` to be useful! Can you please provide a bit more details like: 1. What...

Hey @skjerns . Thanks for the update. Random Forest can indeed be pretty huge sometimes. How many estimators did you end up having? What was the maximum depth of an...

@skjerns I'd say that the difference in binary size is explained by the fact that `m2cgen` and sklearn-porter took quite different approaches to code generation. `m2cgen` encodes the entire model...

Duplicating my question here: @StrikerRUS excellent observation 👍 Do you think we can pull off the same trick as we did for thresholds? Basically cast weights and coefs to float32...