Izaak Schroeder

Results 21 comments of Izaak Schroeder

Thinking of maybe using https://www.npmjs.com/package/es6-error

Thanks for the contribution so far 😄 Will look at this in more detail tonight after I get some rest.

Sorry for the delay, super busy as of late. Feel free to add the dependency 😄 And `babel-cli` should be a `devDependency` for generating `dist`, but that's it I think....

@briancavalier I thought about this a bit before too. I thought maybe I could track the open sessions and then just `Promise.all()` on quitting them but that depends on `leadfoot`...

I'm assuming you moved away from async disposal for perf reasons?

@briancavalier Even if you don't want async disposal back, I think there are a few commits in here you can use anyway. The meat of the async disposal code is...

@briancavalier Yeah. I mean this is just me playing with streams for integration tests right now. I've seen some very heavy lifting by people doing stuff like re-running tests, restarting...

The changes I've made in this PR are enough to cause that "serial" effect to happen and the result is `selenium` is disposed of correctly. If no one is using...

Awesome thanks! 🙏

Hey @briancavalier thanks for the update 😄 1. Yes the relation is 1-to-many. As in 1 selenium server, many sessions. It's a bit clunky, but currently it's 1 new session...