Ilia Yastrebov comments

Results 25 comments of


                                            Ilia Yastrebov

TOOLS/PERF: CI test for perftest daemon

/azp run

UCP: Copy memh flags from parent to child

> @iyastreb can we add a unit test for it? Sure, good idea indeed!

Improve stack memory usage at compile time

I want to express a few concerns about this change. 1. This change might be error prone, because you need to change the flow of every function from return into...

UCT/CUDA_IPC: Redesign peer accessible cache

/azp run

UCS/DATASTRUCT: disable memcopy when passing _old_buffer_p to array_grow

General comment. I understand the importance of this fix, but it still looks a bit strange to me, because of 2 things: 1) IMO it is still error prone to...

GTEST: Mock protocol selection tests

/azp run

GTEST: Mock protocol selection tests

/azp run

GTEST: Mock protocol selection tests

> failure in `rcx/test_ucp_proto_mock.mock_iface_attr/0` looks relevant Yes, this PR is open for a long time, and new changes in master break test assumptions. Fixed

GTEST: Mock protocol selection tests

> @iyastreb can you pls revert the refactoring and only fix review comments and refactor in next pr? Ok, done

UCP/PROTO: Find lanes callback to minimize overhead

> any possibility to add gtest? I added a gtest for this change in previous quickfix commit (https://github.com/openucx/ucx/pull/10630), and that test covers the new behaviour. This PR does not bring...