Iris Chen
Iris Chen
> The goal of this change is to make it so that we have more control over the display of breaking changes in [DIFF_COMMENT.md](https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/magician/cmd/DIFF_COMMENT.md). Currently part of the formatting is...
> LGTM - the unit test improvements are great! Could you temporarily add a breaking change to this PR to verify that the generate_comment behavior still works as expected? Added...
> The goal of this work would be to make it so offline users don't get an error in this case. However, +1 regarding your concerns about side effects; this...
> I think you could either always return the name from ResolveImage if there's no client: > > ```go > func ResolveImage(c *transport_tpg.Config, project, name, userAgent string) (string, error) {...
@melinath I don't think the diff-processor build(function buildDiffProcessor) can tell whether base or head is broken. Also, I am not sure whether we should run a build on either head...
@shuyama1 I rebased, added the datasource detector, and clean up some not used variables. This should be ready to review.
@shuyama1 I created this branch to test the recording - it disabled fetch recording at replay, to trigger replay failure - it only runs the service/compute - it uploads to...
Done! > @iyabchen you'll also need to modify .ci/gcb-vcr-nightly.yml to use the golang version in this PR, similar to #11148. I'll create a testing trigger after.
@shuyama1 - Tests showed that it can do the recording. - I have reverted the debug code. - Main change is to just print warning when upload failed instead of...
Just rebased to latest main