Iris Chen comments

Results 4 comments of


                                            Iris Chen

chore(ci): return jsonify breaking change list

> The goal of this change is to make it so that we have more control over the display of breaking changes in [DIFF_COMMENT.md](https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/magician/cmd/DIFF_COMMENT.md). Currently part of the formatting is...

chore(ci): return jsonify breaking change list

> LGTM - the unit test improvements are great! Could you temporarily add a breaking change to this PR to verify that the generate_comment behavior still works as expected? Added...

fix(tgc): fix resolve image without http client causing panic

> The goal of this work would be to make it so offline users don't get an error in this case. However, +1 regarding your concerns about side effects; this...

fix(tgc): fix resolve image without http client causing panic

> I think you could either always return the name from ResolveImage if there's no client: > > ```go > func ResolveImage(c *transport_tpg.Config, project, name, userAgent string) (string, error) {...