Parnell Springmeyer

Results 91 comments of Parnell Springmeyer

And `terser-webpack-plugin_1-1-0.json` is the package.json for that package _minus_ the `"bin": "",` line, it's the full file but the diff of the file looks like this: ```diff --- package.json 2018-12-13...

Yes leave this open, I still have not reproduced your original issue description.

@paulyoung I was going to the package's github project and the tagged version, then copying the package.json and pretty printing it in Emacs before writing it.

Shouldn't it be: ```nix terser-webpack-plugin_1-1-0 = nodePackagesOld.terser-webpack-plugin_1-1-0.overrideNodePackage (oldDrv: { derivationOverrides.patches = (oldDrv.patches or []) ++ [ ../patches/terser-webpack-plugin_1-1-0.patch ]; }); ```

@fumieval I took a cursory look but I'm just not familiar enough with this C-code to do a good job reviewing it, generally it seems fine though. A more experienced...

@srghma a bug may exist, the semver rules don't have a very good specification sadly. However, it looks like `css-select` only has `1.3.0-rc0` and then `2.0.0` releases; so you can...

Cool, I'll have some free time to devise some CI tests that verify the package overriding behavior is well-behaved too (like, overriding `chokidar` to remove `fsevents`, etc.)

I can concoct a failing case similar to the one we see with our project, I will have time to do that probably this weekend.

~The test suite fails reliably on my own laptop as well as in CI~ ~[grpc-mqtt-0.1.0.0-test.log](https://github.com/awakesecurity/grpc-mqtt/files/10005702/grpc-mqtt-0.1.0.0-test.log)~ [EDIT] I did not run this with mosquito which is necessary for the test suite.